Use isset() instead of in_array() over array_keys() - #12929
Closed
mukeshpanchal27 wants to merge 5 commits into
Closed
Use isset() instead of in_array() over array_keys()#12929mukeshpanchal27 wants to merge 5 commits into
isset() instead of in_array() over array_keys()#12929mukeshpanchal27 wants to merge 5 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
marked this pull request as ready for review
August 10, 2026 04:31
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
pushed a commit
that referenced
this pull request
Aug 11, 2026
…)` for key lookups. This updates several places in core that test whether an array has a given key: * `in_array( $key, array_keys( $array ), true )` allocates a complete copy of every key and walks it. * `isset( $array[ $key ] )`, on the other hand, does a single hash lookup in constant time with no allocation. Note: For arrays that main contain `null` values, [https://www.php.net/manual/en/function.array-key-exists.php#example-2 array_key_exists()] should be used instead. Developed in #12929. Props mukesh27, siliconforks. Fixes #65842. git-svn-id: https://develop.svn.wordpress.org/trunk@63177 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 11, 2026
…)` for key lookups. This updates several places in core that test whether an array has a given key: * `in_array( $key, array_keys( $array ), true )` allocates a complete copy of every key and walks it. * `isset( $array[ $key ] )`, on the other hand, does a single hash lookup in constant time with no allocation. Note: For arrays that main contain `null` values, [https://www.php.net/manual/en/function.array-key-exists.php#example-2 array_key_exists()] should be used instead. Developed in WordPress/wordpress-develop#12929. Props mukesh27, siliconforks. Fixes #65842. Built from https://develop.svn.wordpress.org/trunk@63177 git-svn-id: http://core.svn.wordpress.org/trunk@62374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/65842
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Opus 5
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.